Custom Emojis as a changing prop #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EtienneLem, just making sure you haven't missed this fix. Understand if you're busy. Thanks! |
|
@savardc Oh, thanks for the reminder. |
|
hey @vcervellera-turbulent can you please help me out here ,facing similar issue how to reset react picker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
Encountered issue:
We provide the picker with custom emojis based on different contexts, which means that in certain circumstances, the picker has custom emojis that will not be present at the next opening.
However, the
CUSTOM_CATEGORYemojis array is built outside of thePickerclass, and is kept in memory for all uses of the Picker, and therefore keeps any emojis its provided in memory, even when the Picker receives an emptycustomprop in the future.Fix:
Upon construction of the
Picker, as we check if thecustomprop has no length, I check if theCUSTOM_CATEGORYobject contains emojis with a length, and reset it if so, to avoid contamination.